[SYCL][CUDA][HIP] Update images enable variable #16147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmiller
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
npmiller
commented
Nov 22, 2024
sergey-semenov
approved these changes
Nov 22, 2024
This patch adds a variable to enable image support for HIP, and updates the one for CUDA to use the UR naming. SYCL images support is similar for CUDA and HIP, so it makes sense to treat them the same, and any future work on this will focus on bindless images rather than SYCL images.
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
martygrant
force-pushed
the
images-enable
branch
from
80680d5 to
2950a2f
Compare
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
martygrant
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a variable to enable image support for HIP, and updates
the one for CUDA to use the UR naming.
SYCL images support is similar for CUDA and HIP, so it makes sense to
treat them the same, and any future work on this will focus on bindless
images rather than SYCL images.
UR side PR: oneapi-src/unified-runtime#2356